Refactor: tests to a separated layout, wiki package in src/ #631
Conversation
|
This already caught one error, having had test+development artifacts in the dist tarball/whl on Pypi. It's definitely going to give a much better guarantee that gaps between local development environments and distributed environments don't get confused in the tests: We test the dist, not the dev environment, as the blog post "Packaging a python library" says. |
benjaoming
force-pushed
the
refactor-tests
branch
2 times, most recently
from
fe4583b
to
70e2a89
Compare
benjaoming
force-pushed
the
refactor-tests
branch
from
70e2a89
to
b0edb87
Compare
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 67.92% 67.93% +<.01%
==========================================
Files 87 87
Lines 4337 4335 -2
==========================================
- Hits 2946 2945 -1
+ Misses 1391 1390 -1
Continue to review full report at Codecov.
|
…e .` and the likes
| @@ -64,7 +64,6 @@ def __call__(self, request): | |||
| models.URLPath.root().article, | |||
| self.request.user): | |||
| self.results = self.__filter_can_read(self.request.user) | |||
| #self.results = self.results.filter(current_revision__deleted=False) | |||
| @@ -0,0 +1,2 @@ | |||
| from __future__ import absolute_import | |||
There was a problem hiding this comment.
As of now, it's needed because a lot of HTML files say {% load wiki_thumbnails %} but I don't know if adding the register from sorl actually makes any difference.. I should try deleting it, you're right!
There was a problem hiding this comment.
Just verified it, this is actually the reason :) I think it's to provide a decent wrapper for sorl.thumbnail on case it changes API or we add an alternative. Or maybe it's there for some historic reason.
| @@ -7,8 +7,8 @@ | |||
| from wiki.forms import Group | |||
| from wiki.models import URLPath | |||
|
|
|||
| from .base import wiki_override_settings | |||
| from .testdata.models import CustomGroup | |||
| from ..base import wiki_override_settings | |||
|
Gonna get this merged now and not let it sit in the way of future PRs! |
Refactor:
tests/wikipackage now lives insrc/From Pytest's Good Integration Practices: