Django 2.0 support

[rsalmaso]

I'm testing django-wiki, and I need django 2 support :)
It needs https://github.com/benjaoming/django-nyt/pull/55 because I cannot monkey patch as I've done for django-mptt (already django 2 compatible on master) or django-functest (django-functest/django-functest#14)

[benjaoming]

@rsalmaso was thinking about this a while back -- and to make life easier, I would propose that we release 0.3 as a final release now, without Django 2.0 support.

And then bump master to track a new 0.4 series with just Django 1.11 + 2.0 support?

[rsalmaso]

And maybe without py27 support?
It would be fine!

[benjaoming]

@rsalmaso It's a bit too aggressive to cut 2.7, although I would love to -- the idea behind 1.11 is that it's LTS (so still supported!) and so it helps people to bridge to 2.0... and Python 3 not least!

[rsalmaso]

@benjaoming ok, in 0.4.x support only django>=1.11? it would simplify the patch a bit (remove the is_authenticated/is_anonymous patch) and some urls imports.
But liniting should be ported to python3, because now it fails :)

[benjaoming]

ok, in 0.4.x support only django>1.11?

I would argue >=1.11 because as you can see, 1.11 LTS is supported until April 2020. Think about it like this: Since you yourself just decided to migrate to 2.0, others are still in that same process :) 1.11 support can help them arrive with fewer bumps! :)

But liniting should be ported to python3, because now it fails :)

I'll have that done, too!

[rsalmaso]

yes, it was >=1.11 and not >1.11 (and now corrected :) )

[rsalmaso]

Hi, I've split this PR in 4: #758 #759 #760 (which work with django >= 1.8) and this which explicit add django 2.0 support.
Should be easier this way to review.

[benjaoming]

Thanks @rsalmaso ! Is there something left in this PR to merge? I guess we need to bump django-nyt once released, right?

[rsalmaso]

Yes, it needs a django-nyt compatible with django 2.0 and at least #760 plus probably some cleanup after the 0.3 release.

[benjaoming]

Removing the upper bounds for django-mptt isn't a good idea. This has historically caused brokenness for deployments.

[citxx]

Hi @rsalmaso, thank you a lot for preparing this pull request! I plan to migrate my project to django 2.0 soon and it's great someone has already started making django-wiki ready for this.

Do you still plan to get this pull request merged or should I take over?

[rsalmaso]

I'm back.
PR wip updated, currently it needs a django-nyt with django 2 support release.
I see that python2 is currently dropped 👍

[benjaoming]

@rsalmaso sorry I thought we were waiting for this to release django-nyt with Django 2.0 support: https://github.com/benjaoming/django-nyt/pull/55

[benjaoming]

Hi @rsalmaso !

Just wanted to say that the current django-nyt master has been released to PyPi as 1.1b1 :)

[codecov]

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files          99       99           
  Lines        4335     4335           
=======================================
  Hits         3029     3029           
  Misses       1306     1306

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5918949...ea063be. Read the comment docs.

[rsalmaso]

@benjaoming PR updated!

[benjaoming]

🎉