Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use django.urls where appropriate #795

Merged
merged 3 commits into from Feb 18, 2018
Merged

Use django.urls where appropriate #795

merged 3 commits into from Feb 18, 2018

Conversation

rsalmaso
Copy link
Contributor

@rsalmaso rsalmaso commented Feb 18, 2018

Exctract from #755
Use django.urls if possible (django >= 1.11 compatible)

@codecov
Copy link

codecov bot commented Feb 18, 2018

Codecov Report

Merging #795 into master will increase coverage by 0.03%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   69.85%   69.88%   +0.03%     
==========================================
  Files          99      100       +1     
  Lines        4339     4337       -2     
==========================================
  Hits         3031     3031              
+ Misses       1308     1306       -2
Impacted Files Coverage Δ
src/wiki/plugins/links/wiki_plugin.py 0% <0%> (ø) ⬆️
src/wiki/forms.py 63.5% <100%> (ø) ⬆️
src/wiki/plugins/notifications/wiki_plugin.py 100% <100%> (ø) ⬆️
src/wiki/models/urlpath.py 81.66% <100%> (ø) ⬆️
src/wiki/plugins/attachments/urls.py 100% <100%> (ø) ⬆️
src/wiki/plugins/globalhistory/wiki_plugin.py 100% <100%> (ø) ⬆️
src/wiki/models/__init__.py 82.35% <100%> (+1.31%) ⬆️
src/wiki/plugins/notifications/models.py 67.34% <100%> (ø) ⬆️
src/wiki/models/article.py 83.25% <100%> (ø) ⬆️
src/wiki/urls.py 97.36% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eced6df...7abdf06. Read the comment docs.

try:
from django.urls import re_path as url
except ImportError:
from django.conf.urls import url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's best to move this logic to wiki.core.compat ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, use wiki.compat.
Should move?

@benjaoming benjaoming merged commit f7bab18 into django-wiki:master Feb 18, 2018
@benjaoming benjaoming added the clean-up Code refactoring or removal of stale code label Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Code refactoring or removal of stale code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants