Skip to content

Commit

Permalink
Remove SOCK_NONBLOCK from socket creation on tests (#321)
Browse files Browse the repository at this point in the history
This fixes running tests on Mac OS X, which lacks the `SOCK_NONBLOCK` socket flag creation.
  • Loading branch information
ereslibre committed Apr 1, 2022
1 parent cde961b commit d451a72
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Expand Up @@ -6,7 +6,7 @@ repos:
args: ["--py37-plus"]

- repo: https://github.com/psf/black
rev: 20.8b1
rev: 22.3.0
hooks:
- id: black
args: ["--target-version=py37"]
Expand Down
6 changes: 4 additions & 2 deletions tests/test_server.py
Expand Up @@ -21,7 +21,8 @@ def __init__(self, application, max_applications=1000):
application,
max_applications=max_applications,
)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM)
self._sock.setblocking(False)
self._sock.bind(("127.0.0.1", 0))

@property
Expand Down Expand Up @@ -54,7 +55,8 @@ def close(self):

class Client:
def __init__(self, name):
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM)
self._sock.setblocking(False)
self.name = name

async def register(self, server_addr, name=None):
Expand Down

0 comments on commit d451a72

Please sign in to comment.