Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strict_map_key requirement for deserialize #241

Closed
wants to merge 1 commit into from
Closed

remove strict_map_key requirement for deserialize #241

wants to merge 1 commit into from

Conversation

envirocoder
Copy link

Trying to send a dict with integer keys,
e.g.

async_to_sync(channel_layer.group_send)(
        "name",
        {"type":"test",
        "data": {1:10, 2:20},
        }

I got

  File "msgpack/_unpacker.pyx", line 195, in msgpack._cmsgpack.unpackb
ValueError: int is not allowed for map key

not familiar with the channels or redis code to know if there will be implementations else where; is it safe to relax the checking in msgpack unpacking with strict_map_key=False ?

@envirocoder
Copy link
Author

just noticed, duplicate of #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant