Strip field in order to avoid int conversion crash #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CIF ended with a space the validation crashed with this error: invalid literal for int() with base 10: ''
|
crash tests, pls fixed! |
|
Don't know why all tests are failing but it doesn't seem to be related to my patch. Any idea? |
|
Yes, this doesn’t seem to be relevant. It looks like the lint was updated recently with a new heuristics, that our current code base doesn’t pass. Patch LGTM, would merge if I was a maintainer of the Romanian local flavour. |
|
Merged in cbff146, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CIF ended with a space the validation crashed with this error: invalid literal for int() with base 10: ''