Skip to content

Commit

Permalink
[1.0.X] Fixed #8963 -- Use the require_POST decorator instead of doin…
Browse files Browse the repository at this point in the history
…g things manually in one of the comment views. Thanks, zgoda.

Bakcport of r9121 from trunk.


git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.0.X@9128 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed Oct 5, 2008
1 parent e88b70b commit 245399b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions django/contrib/comments/views/comments.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from django.template import RequestContext
from django.template.loader import render_to_string
from django.utils.html import escape
from django.views.decorators.http import require_POST
from django.contrib import comments
from django.contrib.comments import signals

Expand All @@ -28,11 +29,6 @@ def post_comment(request, next=None):
HTTP POST is required. If ``POST['submit'] == "preview"`` or if there are
errors a preview template, ``comments/preview.html``, will be rendered.
"""

# Require POST
if request.method != 'POST':
return http.HttpResponseNotAllowed(["POST"])

# Fill out some initial data fields from an authenticated user, if present
data = request.POST.copy()
if request.user.is_authenticated():
Expand Down Expand Up @@ -116,6 +112,8 @@ def post_comment(request, next=None):

return next_redirect(data, next, comment_done, c=comment._get_pk_val())

post_comment = require_POST(post_comment)

comment_done = confirmation_view(
template = "comments/posted.html",
doc = """Display a "comment was posted" success page."""
Expand Down

0 comments on commit 245399b

Please sign in to comment.