-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed #20760 -- Reduced timing variation in ModelBackend.
Thanks jpaglier and erikr.
- Loading branch information
Showing
2 changed files
with
27 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dbca13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with this new test, in the case the used test settings are not set to use a MD5-based password hasher.
create_users
called insetUp()
will use the hasher from current settings, thenauthenticate
will fail because of not matching hasher, andCountingMD5PasswordHasher
is never called.A workaround might be to reset self.user password at the start of the test