Skip to content

Commit

Permalink
Revert "[1.5.x] Silenced last sporadic failure on 1.5."
Browse files Browse the repository at this point in the history
This reverts commit 6a708cd.

Reverted since it only moved the failures to some other tests and it apperently
only worked by accident. Patched selenium for now to include:
SeleniumHQ/selenium#118
which seems to be the root cause for sporadic extra requests to the live server,
which then cause all sorts of issues.
  • Loading branch information
apollo13 committed Sep 18, 2013
1 parent 72f7932 commit 87c8de2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tests/regressiontests/forms/tests/widgets.py
Expand Up @@ -1116,12 +1116,6 @@ def test_textarea_trailing_newlines(self):
article = Article.objects.get(pk=article.pk) article = Article.objects.get(pk=article.pk)
# Should be "\nTst\n" after #19251 is fixed # Should be "\nTst\n" after #19251 is fixed
self.assertEqual(article.content, "\r\nTst\r\n") self.assertEqual(article.content, "\r\nTst\r\n")
# So now it's becoming obscure; we do have threading issues here, so this
# test fails sometimes for sqlite, I could only ever witness it on jenkins.
# As long as 1.5 is supported we manually "fix" this test by quitting
# selenium. No idea why closing the browser window isn't enough, but hey…
self.selenium.quit()
delattr(self.__class__, 'selenium')




@python_2_unicode_compatible @python_2_unicode_compatible
Expand Down

0 comments on commit 87c8de2

Please sign in to comment.