Skip to content

Commit

Permalink
Replaced some byte strings by str() calls
Browse files Browse the repository at this point in the history
This is a useful trick when Python 2 awaits byte strings and
Python 3 Unicode (regular) strings.
  • Loading branch information
claudep committed Aug 3, 2012
1 parent 2407c45 commit 9908201
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion django/core/handlers/wsgi.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,6 @@ def __call__(self, environ, start_response):
status = '%s %s' % (response.status_code, status_text)
response_headers = [(str(k), str(v)) for k, v in response.items()]
for c in response.cookies.values():
response_headers.append((b'Set-Cookie', str(c.output(header=''))))
response_headers.append((str('Set-Cookie'), str(c.output(header=''))))
start_response(smart_str(status), response_headers)
return response
18 changes: 9 additions & 9 deletions django/db/backends/sqlite3/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,15 @@ def adapt_datetime_with_timezone_support(value):
default_timezone = timezone.get_default_timezone()
value = timezone.make_aware(value, default_timezone)
value = value.astimezone(timezone.utc).replace(tzinfo=None)
return value.isoformat(b" ")

Database.register_converter(b"bool", lambda s: str(s) == '1')
Database.register_converter(b"time", parse_time)
Database.register_converter(b"date", parse_date)
Database.register_converter(b"datetime", parse_datetime_with_timezone_support)
Database.register_converter(b"timestamp", parse_datetime_with_timezone_support)
Database.register_converter(b"TIMESTAMP", parse_datetime_with_timezone_support)
Database.register_converter(b"decimal", util.typecast_decimal)
return value.isoformat(str(" "))

Database.register_converter(str("bool"), lambda s: str(s) == '1')
Database.register_converter(str("time"), parse_time)
Database.register_converter(str("date"), parse_date)
Database.register_converter(str("datetime"), parse_datetime_with_timezone_support)
Database.register_converter(str("timestamp"), parse_datetime_with_timezone_support)
Database.register_converter(str("TIMESTAMP"), parse_datetime_with_timezone_support)
Database.register_converter(str("decimal"), util.typecast_decimal)
Database.register_adapter(datetime.datetime, adapt_datetime_with_timezone_support)
Database.register_adapter(decimal.Decimal, util.rev_typecast_decimal)
if Database.version_info >= (2, 4, 1):
Expand Down
4 changes: 2 additions & 2 deletions django/db/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ def __new__(cls, name, bases, attrs):

new_class.add_to_class('_meta', Options(meta, **kwargs))
if not abstract:
new_class.add_to_class('DoesNotExist', subclass_exception(b'DoesNotExist',
new_class.add_to_class('DoesNotExist', subclass_exception(str('DoesNotExist'),
tuple(x.DoesNotExist
for x in parents if hasattr(x, '_meta') and not x._meta.abstract)
or (ObjectDoesNotExist,),
module, attached_to=new_class))
new_class.add_to_class('MultipleObjectsReturned', subclass_exception(b'MultipleObjectsReturned',
new_class.add_to_class('MultipleObjectsReturned', subclass_exception(str('MultipleObjectsReturned'),
tuple(x.MultipleObjectsReturned
for x in parents if hasattr(x, '_meta') and not x._meta.abstract)
or (MultipleObjectsReturned,),
Expand Down
2 changes: 1 addition & 1 deletion django/forms/formsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ def formset_factory(form, formset=BaseFormSet, extra=1, can_order=False,
attrs = {'form': form, 'extra': extra,
'can_order': can_order, 'can_delete': can_delete,
'max_num': max_num}
return type(form.__name__ + b'FormSet', (formset,), attrs)
return type(form.__name__ + str('FormSet'), (formset,), attrs)

def all_valid(formsets):
"""Returns true if every formset in formsets is valid."""
Expand Down
4 changes: 2 additions & 2 deletions django/forms/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,10 @@ def modelform_factory(model, form=ModelForm, fields=None, exclude=None,
parent = (object,)
if hasattr(form, 'Meta'):
parent = (form.Meta, object)
Meta = type(b'Meta', parent, attrs)
Meta = type(str('Meta'), parent, attrs)

# Give this new form class a reasonable name.
class_name = model.__name__ + b'Form'
class_name = model.__name__ + str('Form')

# Class attributes for the new form class.
form_class_attrs = {
Expand Down
2 changes: 1 addition & 1 deletion django/http/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# See ticket #13007, http://bugs.python.org/issue2193 and http://trac.edgewall.org/ticket/2256
_tc = http_cookies.SimpleCookie()
try:
_tc.load(b'foo:bar=1')
_tc.load(str('foo:bar=1'))
_cookie_allows_colon_in_names = True
except http_cookies.CookieError:
_cookie_allows_colon_in_names = False
Expand Down

0 comments on commit 9908201

Please sign in to comment.