Fixed #29664 --Caught TypeError exception and giving out meaning full… #10294
Conversation
… error message Please enter the commit message for your changes. Lines starting
There was a problem hiding this comment.
I'm not sure this change needs to occur at all, but can appreciate the frustration of chasing down a bug like this. If we want to go through with providing an error message like this, we need a finer-grained means of determining that the missing .as_view() is what is causing the TypeError.
| response = wrapped_callback(request, *callback_args, **callback_kwargs) | ||
| response = wrapped_callback( | ||
| request, *callback_args, **callback_kwargs) | ||
| except TypeError: |
There was a problem hiding this comment.
What if something else throws this TypeError? If we want to give a message like this at all, I think we need to find a better way of ensuring the case you mentioned is causing it.
|
I agree. This error is actually caused because view class itself is instantiated , when one forgets to call the |
|
I think the best way to detect this would be in |
|
I've marked this If anyone thinks there's a reasonable approach to take please re-open. |
Fixed #29664 --Caught TypeError exception and giving out meaning full error message