Fixed #29928 -- Enabled deferred constraint checks on SQLite 3.20+. #10752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
OK, yep. Great. (I will rebase when merging eb5dd93)
Thanks for the effort!
carltongibson
approved these changes
Dec 14, 2018
Refs django#11665, django#14204. Thanks Michel Samia for the report.
carltongibson
force-pushed
the
ticket-28670
branch
from
985c043
to
3aaf5bd
Compare
timgraham
reviewed
Dec 20, 2018
| @@ -38,6 +38,9 @@ class DatabaseFeatures(BaseDatabaseFeatures): | |||
| # Is "ALTER TABLE ... RENAME COLUMN" supported? | |||
| can_alter_table_rename_column = Database.sqlite_version_info >= (3, 25, 0) | |||
| supports_parentheses_in_compound = False | |||
| # Deferred constraint checks can be emulated on SQLite < 3.20 but not in a | |||
| # reasonably performant way. | |||
| can_defer_constraint_checks = Database.version_info >= (3, 20, 0) | |||
There was a problem hiding this comment.
Is this supposed to be sqlite_version_info rather than version_info? I guess other usages in this file might be incorrect also.
| @@ -265,6 +265,11 @@ Tests | |||
| * The new :setting:`ORACLE_MANAGED_FILES <TEST_ORACLE_MANAGED_FILES>` test | |||
| database setting allows using Oracle Managed Files (OMF) tablespaces. | |||
|
|
|||
| * Deferrable database constraints are now checked at the end of each | |||
| :class:`~django.test.TestCase` test on SQLite 3.20+ as well. These checks | |||
There was a problem hiding this comment.
I think you could drop "as well" (or at least clarify what "as well" refers to). I believe the meaning is that these checks are already performed on other databases.
In fcd08c1, this was also mentioned as a backwards incompatible change.
|
@timgraham both changes make sense, I blindly copy pasted the Would you like me to submit a PR or are you planning to tackle it? |
|
Please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains eb5dd93 which is also part of #10744.