Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #30178 - allow oracle password to be a string-like object: #10983

Closed
wants to merge 1 commit into from

Conversation

danizen
Copy link
Contributor

@danizen danizen commented Feb 11, 2019

  • Provide a test case in tests/backends/oracle/tests.py
  • Provide the most naive fix that could work in django/db/backends/oracle/base.py

@danizen danizen changed the base branch from stable/2.2.x to master February 11, 2019 23:48
- Provide unit test that creates a wrapper object for password,
  Validate failing test with custom oracle settings file (not committed)
- Provide simplest possible fix to Oracle backend.
@jtiai
Copy link

jtiai commented Feb 12, 2019

Is this Oracle only issue or is the issue same with all backends?

@danizen
Copy link
Contributor Author

danizen commented Feb 12, 2019

This ticket is WONTFIX

@danizen danizen closed this Feb 12, 2019
@danizen
Copy link
Contributor Author

danizen commented Feb 13, 2019

Is this Oracle only issue or is the issue same with all backends?

It looks like from the backend code that it would also have been an issue with PostgreSQL, at least for us. The internal password server is in the process of being lifted-and-shifted to the cloud. I really want to avoid depending on this in the cloud. See https://pypi.org/project/confsecrets/ for the beginnings of an attempt to grow a solution past the password server. Abstractly, were I to complete making that module support as backends also S3, Google Cloud Storage, AWS EC2 Secrets manager, and HashiCorp vault, my employer's home grown version would still provide more management of the passwords.

Another interesting thing is to think about Spring config server, relative to Django's settings.

@danizen danizen deleted the ticket-30178 branch February 13, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants