Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30245 -- Added -k option to DiscoverRunner. #11067

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fixed #30245 -- Added -k option to DiscoverRunner. #11067

merged 1 commit into from
Apr 30, 2019

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag force-pushed the unittest_k branch 2 times, most recently from b40cb38 to 964c5c0 Compare March 10, 2019 10:41
timgraham
timgraham reviewed Mar 12, 2019
View reviewed changes
docs/ref/django-admin.txt Outdated Show resolved Hide resolved
docs/ref/django-admin.txt Outdated Show resolved Hide resolved
docs/ref/django-admin.txt Show resolved Hide resolved
django/test/runner.py Outdated Show resolved Hide resolved
django/test/runner.py Show resolved Hide resolved
django/test/runner.py Outdated Show resolved Hide resolved
tests/test_runner/test_discover_runner.py Outdated Show resolved Hide resolved
tests/test_runner/test_discover_runner.py Outdated Show resolved Hide resolved
tests/test_runner/test_discover_runner.py Show resolved Hide resolved
docs/releases/3.0.txt Outdated Show resolved Hide resolved
@francoisfreitag francoisfreitag force-pushed the unittest_k branch 5 times, most recently from b48f035 to 9b3be31 Compare March 14, 2019 11:14
@francoisfreitag francoisfreitag force-pushed the unittest_k branch 2 times, most recently from 12ef848 to 79a8853 Compare March 26, 2019 09:17
@francoisfreitag
Copy link
Contributor Author

Updated to use an adminition for better readability, following guidelines.

@francoisfreitag
Copy link
Contributor Author

Rebased on master, I believe this PR is ready for review.

jdufresne
jdufresne approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm looking forward to using this.

@felixxm felixxm self-assigned this Apr 30, 2019
@felixxm felixxm changed the title Fixed #30245 -- Added --filter argument to test runner. Fixed #30245 -- Added --k option to DiscoverRunner. Apr 30, 2019
@felixxm
Copy link
Member

felixxm commented Apr 30, 2019

I rebased from master and pushed final edits.

@francoisfreitag
Copy link
Contributor Author

francoisfreitag commented Apr 30, 2019 •
edited
Loading

Did you add a test module for Case1Django, Case2Django, etc?

@felixxm
Copy link
Member

felixxm commented Apr 30, 2019

@francoisfreitag Yes, sorry. I wanted to cover cases with trailing and leading *. Now all tests should pass.

@francoisfreitag
Copy link
Contributor Author

francoisfreitag commented Apr 30, 2019 •
edited
Loading

Thanks for making edits and the additional test 👍

@felixxm felixxm merged commit 568eed9 into django:master Apr 30, 2019
@felixxm felixxm changed the title Fixed #30245 -- Added --k option to DiscoverRunner. Fixed #30245 -- Added -k option to DiscoverRunner. Apr 30, 2019
@francoisfreitag francoisfreitag deleted the unittest_k branch April 30, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgraham timgraham timgraham left review comments

@jdufresne jdufresne jdufresne approved these changes

@auvipy auvipy auvipy approved these changes

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@francoisfreitag @felixxm @jdufresne @timgraham @auvipy