Fixed #27462 -- Clarifed difference in m2m_changed pk_set for add() vs remove(). #11792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Sep 18, 2019
There was a problem hiding this comment.
@carltongibson Thanks for this patch 👍 I left some suggestions.
Commit messages proposition:
Refs #27462 -- Added tests of pk_set in m2m_changed signal receivers for repeated add/remove calls.Fixed #27462 -- Clarifed pk_set difference in m2m_changed signal receivers for add() and remove().
|
Cool. Thanks for the review @felixxm. I will go over it tomorrow. 👍 |
…for repeated add/remove calls.
…ivers for add() and remove(). Thank you to Mariusz Felisiak for review.
felixxm
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording. Hmmm.
c.f. #10563.