Fixed #27430 -- Added -b/--buffer option to DiscoverRunner. #12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Dec 9, 2019
There was a problem hiding this comment.
@bmispelon Thanks for this patch 👍 We should be able to test this option (see test_runner/test_discover_runner.py), you can add a new app to the test_runner_apps with tests that will write to the stdout and stderr and check captured output with and without failures.
felixxm
changed the title
bmispelon
force-pushed
the
ticket-27430-unittest-buffer
branch
from
9fbef2d
to
16c330d
Compare
|
Thanks for the review! I've made the changes you requested (in separate commits, I'm not if you prefer that or a whole squahsed commit). |
felixxm
force-pushed
the
ticket-27430-unittest-buffer
branch
from
457a209
to
9e56538
Compare
|
@bmispelon Thanks 👍 I pushed minor edits and simplified tests. |
|
Thanks! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to make it work with parallel test execution
ticket-27430