-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #31292 -- Fixed django.contrib.gis.gdal.gdal_full_version() crash. #12467
Conversation
@vdboor Thanks for the patch. |
Thanks, reading the contributing guide I wondered whether that was needed for such small fix. |
Thanks for the ticket. the ticket is already accepted. |
I accepted the ticket and will write tests for this patch this week, sorry @vdboor if you have already started I cant tell because no one has accepted the ticket. |
c17bd63
to
cd0e605
Compare
cd0e605
to
fc5418c
Compare
Please fix the |
fc5418c
to
c91c4f8
Compare
ok, done! |
c91c4f8
to
e135b75
Compare
e135b75
to
84e35f4
Compare
@vdboor Thanks 👍 I moved tests to a separate file, pushed minor edits, and moved a new test for |
The ctypes signature uses a 'c_char_p' type. The
gdal_version()
was updated in 5330cd5 to reflect that, butgdal_full_version()
wasn't updated. It currently raises: