Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #31123 -- Added --include-stale-apps option to the remove_stale_contenttypes management command. #12558

Closed
wants to merge 9 commits into from
Closed

Fixed #31123 -- Added --include-stale-apps option to the remove_stale_contenttypes management command. #12558

wants to merge 9 commits into from

Conversation

gowthamk63
Copy link
Contributor

@kingbuzzman
Copy link
Contributor

Can you add "Refs #31123" to the beginning of the PR title

@gowthamk63 gowthamk63 changed the title remove stale content types for non existent apps Refs #31123: remove stale content types for non existent apps Mar 11, 2020
felixxm
felixxm reviewed Mar 18, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gowthamk63 Thanks for this patch 👍 Please add release notes and update docs.

django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
@kingbuzzman
Copy link
Contributor

@felixxm this will be in 3.1 correct?

@felixxm
Copy link
Member

felixxm commented Mar 18, 2020

Yes, if it will be ready on time👍

@kingbuzzman
Copy link
Contributor

@felixxm let me know if there is anything we need to fix. Thanks.

felixxm
felixxm reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gowthamk63 @kingbuzzman Thanks for docs 👍

django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
django/contrib/contenttypes/management/commands/remove_stale_contenttypes.py Outdated Show resolved Hide resolved
tests/contenttypes_tests/test_management.py Show resolved Hide resolved
tests/contenttypes_tests/test_management.py Show resolved Hide resolved
docs/ref/django-admin.txt Show resolved Hide resolved
@felixxm felixxm changed the title Refs #31123: remove stale content types for non existent apps Fixed #31123 -- Added --include-stale-apps option to the remove_stale_contenttypes management command. Mar 19, 2020
@felixxm felixxm self-assigned this Mar 19, 2020
@kingbuzzman
Copy link
Contributor

@felixxm thanks for all your help, please let us know of any further changes needed. Thanks.

@felixxm
Copy link
Member

felixxm commented Mar 19, 2020

@gowthamk63 @kingbuzzman Thanks 👍 I pushed final edits.

@felixxm
Copy link
Member

felixxm commented Mar 19, 2020 •
edited
Loading

OK I cannot push them, Can you allow me to push final edits?
image

@kingbuzzman
Copy link
Contributor

I will tell @gowthamk63 to do this as soon as possible, he is asleep at the moment.

@kingbuzzman
Copy link
Contributor

kingbuzzman commented Mar 19, 2020 •
edited
Loading

@felixxm He will be another 2 hours, if you want, you can paste the diff and i can apply it so we're not waiting around. I can modify the branch not the PR.

@felixxm felixxm mentioned this pull request Mar 19, 2020
Merged
@felixxm
Copy link
Member

felixxm commented Mar 19, 2020

@kingbuzzman np, I opened a new PR with final edits.

Updated in #12588.

@felixxm felixxm closed this Mar 19, 2020
@kingbuzzman
Copy link
Contributor

@felixxm can i copy over your changes to this PR and re-open this PR, issue is that if you merge that new PR @gowthamk63 wont get a "Contributor" badge.

@felixxm
Copy link
Member

felixxm commented Mar 19, 2020

I'm not sure what a "Contributor" badge means, but if you want I can make him the main author of this change.

@kingbuzzman
Copy link
Contributor

kingbuzzman commented Mar 19, 2020 •
edited
Loading

@felixxm please.

image

This is what i mean, if you've had a PR merged into a project, you get this.

@felixxm
Copy link
Member

felixxm commented Mar 19, 2020

Done.

@kingbuzzman kingbuzzman deleted the 31123-remove-stale-content-types branch March 19, 2020 11:39
@smithdc1 smithdc1 mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingbuzzman kingbuzzman kingbuzzman left review comments

@felixxm felixxm felixxm left review comments

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gowthamk63 @kingbuzzman @felixxm