Fixes #31511 -- Remove the part of URLify that removes English stop words #12785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior seems outdated and no longer desirable, for the reasons presented in the ticket and earlier django-developers mailing list conversation. Co-Authored-By: Andy Chosak <andy@chosak.org>
Scotchester
force-pushed
the
rm-urlify-stop-word-removal
branch
from
921ea24
to
086029c
Compare
|
@Scotchester Thanks, however this behavior should be first deprecated (which can be tricky) (see the deprecation policy). Also, I'm not convince that one supportive comment is enough to reopen ticket-11157 and change this behavior. |
|
Closing per ticket-11157 (at least for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will close ticket #31511: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields.
With: @chosak