Set .vUUIDField class on admin UUIDFields used as raw_id_fields #12926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raw_id_fields get the css class vForeignKeyRawIdAdminField, which limits the width to roughly 9 characters. UUIDs are often used as primary keys. This commit makes it so that UUIDs set to be a raw_id_field in the admin also get the vUUIDField css class, which sets a larger width which can fit 36 characters.
jdufresne
reviewed
Jun 4, 2020
Comment on lines
+153
to
+154
| if isinstance(rel_to._meta.pk, UUIDField): | ||
| context['widget']['attrs']['class'] += ' ' + 'vUUIDField' |
There was a problem hiding this comment.
I think a test could be added to show when this class is rendered.
There was a problem hiding this comment.
I just tried adding a test for this but honestly am spending far too long on it; I'm not familiar enough with the way the test suite is rendering those admin fields.
|
Hi -- may I ask you to fill out a ticket? Most PRs aren't noticed without one. |
|
Superseded by #15136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw_id_fields get the css class vForeignKeyRawIdAdminField, which limits
the width to roughly 9 characters.
UUIDs are often used as primary keys. This commit makes it so that UUIDs
set to be a raw_id_field in the admin also get the vUUIDField css class,
which sets a larger width which can fit 36 characters.