Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs 31617: Improved admin contrast #12967

Closed
wants to merge 4 commits into from
Closed

Refs 31617: Improved admin contrast #12967

wants to merge 4 commits into from

Conversation

xi
Copy link
Contributor

@xi xi commented May 24, 2020

As I know changing brand colors is always controversial I tried to reuse existing colors where possible.

@claudep
Copy link
Member

claudep commented May 24, 2020

I think it would be worth asking on the mailing list about possible usage for CSS variables (https://developer.mozilla.org/en-US/docs/Web/CSS/var). This would ease a lot updating of colors.

@felixxm
Copy link
Member

felixxm commented May 25, 2020

@xi Thanks for this patch, however we need a wider discussion and DEP before we'll move it forward, see comment.

Closing per ticket.

@felixxm felixxm closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xi @claudep @felixxm