Ticket #20687 -- Added documentation for django.core.signing API. #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,6 +183,11 @@ def sign(self, value): | |||
| return super(TimestampSigner, self).sign(value) | |||
|
|
|||
| def unsign(self, value, max_age=None): | |||
| """ | |||
| Retrieve original value and check it wasn't signed longer than | |||
There was a problem hiding this comment.
rephrase: signed more than max_age seconds ago (also remove extra newline in docstring)
There was a problem hiding this comment.
Extra newline is suggested in PEP 8 http://www.python.org/dev/peps/pep-0008/#documentation-strings
However, I'll try to rephrase it and maybe it fits to oneline.
There was a problem hiding this comment.
I'd prefer to keep the docstring consistent with those in the rest of the file (which don't have the extra line).
There was a problem hiding this comment.
Sure, I've deleted it. I didn't check the rest of the file before.
|
merged in c5bc98d, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/20687