Fixed #31863 -- Prevented mutating model state by copies of model instances. #13281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GertBurger
commented
Aug 7, 2020
felixxm
changed the title
felixxm
reviewed
Aug 7, 2020
GertBurger
force-pushed
the
#31863-model-field-cache-copy
branch
from
f04ec81
to
a019411
Compare
felixxm
reviewed
Aug 10, 2020
GertBurger
force-pushed
the
#31863-model-field-cache-copy
branch
2 times, most recently
from
368cd37
to
6f9635c
Compare
…tances. Regression in bfb746f.
felixxm
force-pushed
the
#31863-model-field-cache-copy
branch
from
6f9635c
to
94ea79b
Compare
|
@GertBurger Thanks 👍 Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket-31863
Discussion at https://groups.google.com/g/django-developers/c/QMhVPIqVVP4/m/kcvbnCn0AwAJ
Django 2.0 introduced a fields cache for model fields which ends up being copied during a model instance copy. This results in changes to the new model instance unexpectedly affecting the original model instance (last 2 asserts in test fails). In Django 1.11 and earlier the behavior was as expected when using copy.
This is my first PR to the Django project so please point out any thing I missed whilst reading the contributor guidelines. CLA was submitted last night.