Fixed #26615 -- Made password reset token invalidate when changing email. #13551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
changed the title
|
Hi Jacob. I think you may need to look at over riding |
|
Thanks @dcsmith1, in skimming the unmerged PRs I didn't see much discussion around the test, and so it escaped my notice that it wasn't targeting the reported behavior. This should fail without my patch. |
felixxm
changed the title
felixxm
force-pushed
the
password_reset_hash
branch
from
d781591
to
bb4a35d
Compare
|
Thanks for improvements @felixxm, including correcting the nullable field test! :/ |
carltongibson
approved these changes
Oct 21, 2020
…ail. Co-Authored-By: Silas Barta <sbarta@gmail.com>
felixxm
force-pushed
the
password_reset_hash
branch
from
bb4a35d
to
0362b0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket-26615
Thanks to @SilasX for authoring the test.
Previous discussion in pull requests #6868, #6621, although this patch is more concise.
UPDATE: If it's conceivable thatDone.EMAIL_FIELDcould be nullable, this may warrant more handling.