Fixed #32226 QuerySet.explain(format='json') outputs repr'd JSON on PostgreSQL #13867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket 32226
Fixed #32226 -- changed format from str to json
Fixed #32226 changes for isort issue
Ticket 32226
Fixed #32226 isort issue
Ticket 32226
final isort fix
Uday-kiran007
changed the title
|
@felixxm could you please check and review ? |
|
Please don't @ the fellows for review. They review tickets that are marked as ready on trac in time. You have test failures and merge conflicts. Please rebase the branch to fix the conflicts and address the test failures. |
adamchainz
reviewed
Feb 22, 2021
| return '\n'.join(compiler.explain_query()) | ||
| if connection.vendor == 'postgresql': | ||
| if format == 'json': | ||
| return json.loads(json.dumps(ast.literal_eval('\n'.join(compiler.explain_query()))))[0] |
There was a problem hiding this comment.
I don't think the ast.literal_eval approach is the best. I only included the code as an example on the ticket. It would be better to never force the result into a string in the first place.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.