Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend django<4 on older versions of Python #14263

Closed
wants to merge 1 commit into from

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Apr 14, 2021

It seems odd to recommend an unsupported version of Django on Python < 3.8

@ngnpope
Copy link
Member

ngnpope commented Apr 14, 2021

Make sure you have pip >= 9.0 and setuptools >= 24.2, then try again...

I've asked @carltongibson this before - there were long discussions in #12013 - but perhaps it is time for considering it again: Can we drop this check now and assume that users have a new enough version of pip and setuptools to support python_requires?

pip==9.0.0 was released on Nov 2, 2016 and setuptools==24.2.0 was released on Jul 21, 2016. By the time Django 4.0 is released in December this year, it'll be over five years and closing on two years since the Python 2 EOL which was the main concern when this was last brought up.

@carltongibson
Copy link
Member

Hey @pope1ni — I was literally just about to ping you. 😀

IMO, yep, it's time for all of this to go. (@felixxm You have opinions?)

@@ -28,7 +28,7 @@
version of Python. If you can't upgrade your pip (or Python), request
an older version of Django:

$ python -m pip install "django<2"
$ python -m pip install "django<4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11 was the last version compatible with Python 2 though no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but as REQUIRED_PYTHON is 3.8, if CURRENT_PYTHON were 3.7, this would trigger. You'd be told to install django<2 when higher versions are supported by Python 3.7.

@ngnpope
Copy link
Member

ngnpope commented Apr 14, 2021

IMO, yep, it's time for all of this to go.

See #14264.

@carltongibson
Copy link
Member

Ok, super. @jaap3 I'm going to close this in favour of the more ambitious approach. Thanks.

@jaap3
Copy link
Contributor Author

jaap3 commented Apr 14, 2021

No problem, happy to be the catalyst of more ambitious approaches ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants