Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend django<4 on older versions of Python #14263

Closed
wants to merge 1 commit into from
Closed

Recommend django<4 on older versions of Python #14263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@
version of Python. If you can't upgrade your pip (or Python), request
an older version of Django:

$ python -m pip install "django<2"
$ python -m pip install "django<4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11 was the last version compatible with Python 2 though no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but as REQUIRED_PYTHON is 3.8, if CURRENT_PYTHON were 3.7, this would trigger. You'd be told to install django<2 when higher versions are supported by Python 3.7.

""".format(*(REQUIRED_PYTHON + CURRENT_PYTHON)))
sys.exit(1)

Expand Down