-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #28935 -- Fixed display of errors in extended blocks. #14367
Conversation
Hi @cammil can you update this PR with the correct ticket number? Thanks. And please make sure the ticket links to the PR also. |
@jacobtylerwalls Sorry for the wrong ticket number. Not sure how that happened! I've updated title with the correct number. TIcket links back to this PR correctly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cammil Thanks for this patch 👍
I pushed small edits.
Get the template that caused the exception and get the exception info from that template, using the node that caused the exception.
First, thanks to all of you for this fix. I had the same problem and went to the bug reporter and found this. However, I note that version 3.2.5 was released July 1, and this patch was committed July 2, but the release of 3.2.6 says nothing about this patch in the bugfixes. So if I upgrade to 3.2.6 will I get this patch or not? If not, when, and if not soon, how easy / hard do I apply it myself? |
Hi @MalikRumi, the ticket being fixed was reported in 2017. We regularly merge patches fixing long-standing bugs, but unless the bugs were introduced in the last version of Django (3.2) or affect security or data loss, they aren't backported, which is to say, it will be included in Django 4.0 only. Django 4.0 alpha comes out in about a month, then a beta, then final release early December (timeline). (You can pin to the |
hmmm. Ok, well, before I found this bug report, I was thinking about writing a custom error. In my immediate use case, the error is being called when I try to bring up a list of objects. But the NoReverseMatch error references a detail page. There are a lot of detail pages (url tags) on this list, so not knowing exactly which one is causing the problem, and why, means some slow and painful one - at - a - time checking. Would it be possible to write a custom error that would bring me this information? I'm not sure exactly how I would do that, and I don' expect you to write me a tutorial, but if you can point me to some good resources for how to go about it in this situation, that would be great. Thanks. |
@MalikRumi If you look at the PR the actual code change is pretty straightforward, so you could just modify your installed django. |
Fixed #27694 -- Exception debug info on correct template.