Completed test coverage for django.utils.dateformat and simplified some formats. #14415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
force-pushed
the
cleanup-dateformat
branch
2 times, most recently
from
4895ff1
to
3673e2e
Compare
ngnpope
changed the title
django.utils.dateformat coverage to 100% and simplified some formats.
ngnpope
force-pushed
the
cleanup-dateformat
branch
from
3673e2e
to
bfced47
Compare
ngnpope
force-pushed
the
cleanup-dateformat
branch
from
bfced47
to
bfe9bba
Compare
|
@felixxm I've rebased this one. Your #14602 (comment) mentioned that this PR might address use of |
felixxm
reviewed
Jul 13, 2021
felixxm
reviewed
Jul 13, 2021
ngnpope
force-pushed
the
cleanup-dateformat
branch
from
bfe9bba
to
6049337
Compare
|
Thanks @felixxm. Updated. |
This removes unnecessary format('O') call, remove unnecessary method
calls for simple cases in TimeFormat, and simplifies time zone handling
in TimeFormat.
felixxm
changed the title
django.utils.dateformat coverage to 100% and simplified some formats.
felixxm
changed the title
felixxm
force-pushed
the
cleanup-dateformat
branch
from
6049337
to
1f4908b
Compare
|
@pope1ni Thanks 👍 I reorganized commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left this split into separate commits to make it easier to follow.