Skip to content

Conversation

abhiabhi94
Copy link
Contributor

Thanks Keryn Knight for the report.

@felixxm felixxm changed the title Fixed #32904 -- Made regex for parse_time() more accurate. Fixed #32904 -- Made parse_time() more strict. Jul 7, 2021
@abhiabhi94 abhiabhi94 force-pushed the fix/parse_time_regex branch 2 times, most recently from e5053c8 to 8a161bf Compare July 7, 2021 08:31
@felixxm felixxm self-assigned this Jul 7, 2021
Thanks Keryn Knight for the report.
@felixxm felixxm force-pushed the fix/parse_time_regex branch from 8a161bf to cf6774a Compare July 7, 2021 10:09
@felixxm
Copy link
Member

felixxm commented Jul 7, 2021

@abhiabhi94 Thanks 👍 I added 3 more assertions.

@abhiabhi94
Copy link
Contributor Author

Thanks, @felixxm. You may as well point me in the direction of any changes that you may want. I will try to make those changes by myself so that you don't potentially spend time on having to do any extra work in future on the patches.

@abhiabhi94
Copy link
Contributor Author

Also, for what it is worth, I think we may use subTest here when checking for different values v/s writing the same function call again.

@felixxm
Copy link
Member

felixxm commented Jul 7, 2021

Also, for what it is worth, I think we may use subTest here when checking for different values v/s writing the same function call again.

This is a separate cleanup, addressed in #14415 (at least partly).

@felixxm felixxm merged commit cf6774a into django:main Jul 7, 2021
@ngnpope
Copy link
Member

ngnpope commented Jul 7, 2021

This is a separate cleanup, addressed in #14415 (at least partly).

I'll rebase that tonight and see if anything else needs addressing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants