Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert". #14586

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert". #14586

merged 1 commit into from
Jul 5, 2021

Conversation

mateoradman
Copy link
Contributor

Replace assert with ImproperlyConfigured in django.db.backends.postgresql.creation and replace assert with TypeError in django.test.testcases

@felixxm
Copy link
Member

felixxm commented Jul 2, 2021

@mateoradman Thanks 👍 Please fix flake errors and add tests for error messages.

@felixxm felixxm changed the title Refs #32508 - Replace assert by raising an exception in django.db.backends.postgresql.creation and django.test.testcases Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert". Jul 5, 2021
felixxm
felixxm reviewed Jul 5, 2021
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateoradman Thanks 👍 I pushed minor edits.

tests/backends/postgresql/test_creation.py Outdated Show resolved Hide resolved
@felixxm felixxm merged commit 2231429 into django:main Jul 5, 2021
@mateoradman mateoradman deleted the #ticket_32508 branch July 7, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mateoradman @felixxm