Fixed #33060 -- Added BaseCache.make_and_validate_key() hook. #14802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ngnpope
force-pushed
the
ticket-33060
branch
2 times, most recently
from
42a14ad
to
97e570a
Compare
ngnpope
commented
Aug 26, 2021
cjerdonek
reviewed
Aug 27, 2021
|
Merged the 3rd commit in 68b8eda. |
felixxm
force-pushed
the
ticket-33060
branch
from
576923f
to
670d5ff
Compare
|
@ngnpope Thanks 👍 I rebased and pushed edits to tests. |
felixxm
changed the title
ngnpope
commented
Sep 3, 2021
felixxm
force-pushed
the
ticket-33060
branch
from
670d5ff
to
1f6bfb9
Compare
carltongibson
approved these changes
Sep 7, 2021
The validate_key() function should be called after make_key() to ensure that the validation is performed on the key that will actually be stored in the cache. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This helper function reduces the amount of duplicated code and makes it easier to ensure that we always validate the keys.
|
@carltongibson Thanks for the review 👍 Suggestions applied. |
felixxm
force-pushed
the
ticket-33060
branch
from
1f6bfb9
to
42dfa97
Compare
|
Thanks for polishing this off @felixxm 🦸🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket-33060
Following on from #14437 (comment).