Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #33060 -- Added BaseCache.make_and_validate_key() hook. #14802

Merged
merged 3 commits into from Sep 7, 2021
Merged

Fixed #33060 -- Added BaseCache.make_and_validate_key() hook. #14802

merged 3 commits into from Sep 7, 2021

Commits on Sep 7, 2021

  1. Refs #33060 -- Added memcached test for make_key() making keys invalid.

    @felixxm
    felixxm committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ec2f6ea View commit details
    Browse the repository at this point in the history

  2. Refs #33060 -- Ensured cache backends validate keys. 

    The validate_key() function should be called after make_key() to ensure
that the validation is performed on the key that will actually be
stored in the cache.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
    @ngnpope @felixxm
    ngnpope and felixxm committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    4b82578 View commit details
    Browse the repository at this point in the history

  3. Fixed #33060 -- Added BaseCache.make_and_validate_key() hook. 

    This helper function reduces the amount of duplicated code and makes it
easier to ensure that we always validate the keys.
    @ngnpope @felixxm
    ngnpope authored and felixxm committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    42dfa97 View commit details
    Browse the repository at this point in the history