Fixed #33426 -- Fixed ResolverMatch.__repr_() for class-based views. #15297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kezabelle Thanks 👍 Can you add release notes? |
kezabelle
force-pushed
the
tickets/33426
branch
from
79371fd
to
e739492
Compare
|
Dangerous of you to let me attempt to construct release notes that are stylistically correct, but yep, done/attempted :) |
felixxm
force-pushed
the
tickets/33426
branch
from
e739492
to
f4b06a3
Compare
felixxm
changed the title
|
@kezabelle Thanks 👍 I pushed tiny edits to release notes 😉 @ngnpope @adamchainz @tim-mccurrach Do you want to take a look? |
|
LGTM |
|
Thanks y'all for checking 👍 |
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket is 33426.
I think this is an issue based on my recollection of the ResolverMatch behaviour going back however long, but short of pulling in python 2.7 and going back to the early 1.x series, I can only say it looks like a difference between
3.2.9and4.0Tests looked to pass locally, so let's see if this works generally.