Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed outdated handling of length parameter to If-Modified-Since header. #15500

Merged
merged 1 commit into from Mar 15, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 11, 2022

The length parameter is not described in RFC-7232 and it's against HTTP/1.0 and HTTP/1.1 specifications. It was an old and unofficial extension set by some ancient versions of IE.

@felixxm
Copy link
Member Author

felixxm commented Mar 11, 2022

@collinanderson Can you take a look?

@felixxm felixxm requested a review from a team March 11, 2022 10:01
Copy link
Contributor

@collinanderson collinanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've never seen ; length= before, and I'm not seeing it in the spec.

was_modified_since is undocumented, but maybe it's worth adding a tiny release note about the size parameter being removed, just in case?

Either way, looks good to me.

@felixxm
Copy link
Member Author

felixxm commented Mar 11, 2022

Thanks for reviews 👍 was_modified_since() is an internal API so release notes should be enough.

…ader.

The length parameter is not described in RFC-7232 and it's against
HTTP/1.0 and HTTP/1.1 specifications. It was an old and unofficial
extension set by some ancient versions of IE.
@felixxm felixxm merged commit be80aa5 into django:main Mar 15, 2022
@felixxm felixxm deleted the If-Modified-Since-length branch March 15, 2022 12:08
lb- pushed a commit to felixxm/wagtail that referenced this pull request Mar 22, 2022
…ader

- The length parameter is not described in RFC-7232 and it's against HTTP/1.0 and HTTP/1.1 specifications.
- It was an old and unofficial extension set by some ancient versions of IE.
- See https://httpwg.org/specs/rfc7232.html#header.if-modified-since
- django/django#15500
lb- pushed a commit to wagtail/wagtail that referenced this pull request Mar 22, 2022
…ader

- The length parameter is not described in RFC-7232 and it's against HTTP/1.0 and HTTP/1.1 specifications.
- It was an old and unofficial extension set by some ancient versions of IE.
- See https://httpwg.org/specs/rfc7232.html#header.if-modified-since
- django/django#15500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants