Removed outdated handling of length parameter to If-Modified-Since header. #8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://felixxmwas-modified-since-size-d89xj.squash.io |
lb-
added
status:Needs Review
Compatibility
|
@felixxm thanks so much for taking the time to contribute, I have flagged this as needs review. Note for when this gets merged in, we should probably use the similar release note warning as in Django (but with our function name of course). |
felixxm
force-pushed
the
was_modified_since_size
branch
from
bd27a58
to
965d293
Compare
|
@lb- Thanks for checking 👍 I added a small release note. |
…ader - The length parameter is not described in RFC-7232 and it's against HTTP/1.0 and HTTP/1.1 specifications. - It was an old and unofficial extension set by some ancient versions of IE. - See https://httpwg.org/specs/rfc7232.html#header.if-modified-since - django/django#15500
lb-
force-pushed
the
was_modified_since_size
branch
from
965d293
to
a42f1be
Compare
lb-
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
@felixxm thanks for this and thanks for making your first contribution to Wagtail, great to see you over in this neck of the woods :D
I have rebased/added release notes and pushed to your remote branch, will merge in shortly.
I have added you to the contributors list as Mariusz Felisiak, please let me know if you wanted your name listed differently.
|
@lb- Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length parameter is not described in RFC-7232 and it's against HTTP/1.0 and HTTP/1.1 specifications. It was an old and unofficial extension set by some ancient versions of IE.
See also django/django#15500.