Refs #27064 -- Added RenameIndex migration operation. #15677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
May 11, 2022
|
Thanks a lot for the review @felixxm 🙏
|
felixxm
changed the title
felixxm
reviewed
May 12, 2022
There was a problem hiding this comment.
@David-Wobrock Thanks for updates 👍 I rebased and pushed some edits.
django/db/backends/oracle/schema.py
Outdated
| @@ -27,6 +27,7 @@ class DatabaseSchemaEditor(BaseDatabaseSchemaEditor): | |||
| ) | |||
| sql_delete_table = "DROP TABLE %(table)s CASCADE CONSTRAINTS" | |||
| sql_create_index = "CREATE INDEX %(name)s ON %(table)s (%(columns)s)%(extra)s" | |||
| sql_renamed_index = "ALTER INDEX %(old_name)s RENAME TO %(new_name)s" | |||
There was a problem hiding this comment.
Typo:
Suggested change
| sql_renamed_index = "ALTER INDEX %(old_name)s RENAME TO %(new_name)s" | |
| sql_rename_index = "ALTER INDEX %(old_name)s RENAME TO %(new_name)s" |
| ) | ||
| if len(matching_index_name) != 1: | ||
| raise ValueError( | ||
| f"Found wrong number ({len(matching_index_name)}) of indexes for " |
There was a problem hiding this comment.
f-strings should not contain function calls. This guideline is from Python coding style.
| if self.old_fields: | ||
| from_model = from_state.apps.get_model(app_label, self.model_name) | ||
| matching_index_name = schema_editor._constraint_names( | ||
| from_model, column_names=self.old_fields, index=True |
There was a problem hiding this comment.
Users would use field names not column names 🤔 we must take this into account, e.g.
columns = [from_model._meta.get_field(field).column for field in self.old_fields]
tests/migrations/test_operations.py
Outdated
Comment on lines
3025
to
3066
| def test_rename_index_reduction(self): | ||
| operation_one = migrations.RenameIndex( | ||
| "Pony", new_name="mid_name", old_fields=("weight", "pink") | ||
| ) | ||
| operation_two = migrations.RenameIndex( | ||
| "Pony", new_name="new_name", old_name="mid_name" | ||
| ) | ||
| result_operations = operation_one.reduce(operation_two, []) | ||
| self.assertEqual(len(result_operations), 1) | ||
| self.assertEqual( | ||
| result_operations[0].deconstruct(), | ||
| migrations.RenameIndex( | ||
| "Pony", | ||
| new_name="new_name", | ||
| old_fields=("weight", "pink"), | ||
| ).deconstruct(), | ||
| ) | ||
|
|
||
| operation_one = migrations.RenameIndex( | ||
| "Pony", new_name="mid_name", old_name="old_name" | ||
| ) | ||
| operation_two = migrations.RenameIndex( | ||
| "Pony", new_name="new_name", old_name="mid_name" | ||
| ) | ||
| result_operations = operation_one.reduce(operation_two, []) | ||
| self.assertEqual(len(result_operations), 1) | ||
| self.assertEqual( | ||
| result_operations[0].deconstruct(), | ||
| migrations.RenameIndex( | ||
| "Pony", new_name="new_name", old_name="old_name" | ||
| ).deconstruct(), | ||
| ) | ||
|
|
||
| operation_one = migrations.RenameIndex( | ||
| "Pony", new_name="mid_name", old_name="old_name" | ||
| ) | ||
| operation_two = migrations.RenameIndex( | ||
| "Pony", new_name="new_name", old_fields=("weight", "pink") | ||
| ) | ||
| result_operations = operation_one.reduce(operation_two, []) | ||
| self.assertIs(result_operations, False) | ||
|
|
|
Awesome, thanks a lot for the edits @felixxm 🚀 |
David-Wobrock
commented
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds for https://code.djangoproject.com/ticket/27064 the
RenameIndexoperationSplit from #15651. Here we implement the operation, in #15651 we use it in the autodetector.
This PR:
RenameIndexoperation, that nearly always has 2 behaviours for each method: 1/ renaming with anold_nameor renaming an unnamed index withold_fieldsindexesor bothindexes+index_togethersupports_index_renamingfeature flag on DB backends, to know if one can use aRENAME INDEXdatabase statement or needs to drop/create the index