New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #30947 -- Changed tuples to lists where appropriate. #16003
Conversation
@felixxm thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgax Thanks 👍
cac0179
to
de6c9c7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
How this could break your CI? 🤔 First of all it's almost a purely documentation change. Secondly, it was not backported to Django 4.1. |
It's documented as a small breaking change, see release notes:
|
@felixxm Yep, thanks :) I swear I did read it there 😁 but as said, I had to skip 4.1.0 altogether due to the accidental GDAL dependency so this never cropped up then. All good now, a bit of refactoring and I have |
The patch is split into 4 commits, hopefully making it easier to review.
Most of the tuples that got changed were found by searching the files with a regexp. Only the code in
django/contrib/*/models*
was searched because that's the scope defined in the ticket. TBH I'm not sure if the changes to the docs should have been part of the ticket, but here they are :)