Fixed #33886 -- Reallowed using GeoIP2() when GEOS is not installed. #15906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
geoip-no-require-gdal
branch
from
2f08f02
to
dea2da1
Compare
|
I'm fine with reverting the commit, but we should then add a comment explaining why the import is not on top of the file (to avoid redoing the same later). |
|
@claudep Grand idea, |
akx
force-pushed
the
geoip-no-require-gdal
branch
from
dea2da1
to
53ecc85
Compare
felixxm
changed the title
django.contrib.gis.geos.
felixxm
force-pushed
the
geoip-no-require-gdal
branch
from
53ecc85
to
e7afb8a
Compare
|
@akx Thanks 👍 I added a release note. |
|
Thanks 🤦♂️ Makes sense - the lack of comment before led to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 31bef51 to allow using the GeoIP module without GDAL installed.
Refs https://code.djangoproject.com/ticket/33886
Refs #15146