Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL. #16134

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Sep 29, 2022

Thanks Anders Kaseorg for the report.

Regression in 2eea361.

ticket-34058

@felixxm felixxm changed the title Fixed #34058 -- Changed serial to identity columns when altering type on PostgreSQL. Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL. Sep 29, 2022
@felixxm
Copy link
Member Author

felixxm commented Sep 29, 2022

@andersk Can you confirm if it works for you?

…uto fields on PostgreSQL.

Thanks Anders Kaseorg for the report.

Thanks Florian Apolloner for pair programming.

Regression in 2eea361.
@andersk
Copy link
Contributor

andersk commented Sep 29, 2022

Yes, this seems to work.

@felixxm
Copy link
Member Author

felixxm commented Sep 29, 2022

Yes, this seems to work.

Many thanks for your confirmation 🎉

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice test 😅

@felixxm
Copy link
Member Author

felixxm commented Sep 29, 2022

Thanks for reviews 🌟

@felixxm felixxm merged commit 19e6efa into django:main Sep 29, 2022
@felixxm felixxm deleted the issue-34058 branch September 29, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants