Bugfix/28404 showing empty value for empty strings in django admin #17699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
4 times, most recently
from
ae74bef
to
45bd83e
Compare
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
45bd83e
to
a2d87b0
Compare
|
I need to look a bit deeper into this and maybe make some changes. So to not waste anybody's time I'm closing the pull request for now and going to reopen it once I got some more insight. |
|
I now check for |
|
Reopening the PR |
|
Opened a new pull request here (Can't edit the ticket right now ...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to pickup ticket 28404 again. Prior PRs are #9391 #8776 and #9390 .
This is my first PR for Django, addressing not showing the empty_display_value if value is the empty string and not None in the admin app. Please advise as you see fit.