Fixed #28404 -- Made displaying values in admin respect Field's empty_values. #17702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 8, 2024
`test_null_display_for_field` is replaced by - `test_empty_value_display_for_field` - `test_empty_value_display_choices` - `test_empty_value_display_booleanfield` PR recommendation by @felixxm django#17702 (comment)
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 8, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
7627fb0
to
ce1c14c
Compare
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 8, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
2 times, most recently
from
6017785
to
a330fbb
Compare
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 8, 2024
|
I added a new test |
|
Two tests failed because of "TimeoutError: SMTP server started, but not responding within allotted time. This might happen if the system is too busy. Try increasing the I guess this just temporary? Can I trigger the test run again (without doing another commit)? |
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 8, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
a330fbb
to
c36dc38
Compare
e11bits
changed the title
|
I merged the first commit, 1b0a899. Please rebase. |
felixxm
reviewed
Jan 9, 2024
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 9, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
c36dc38
to
dd2eca2
Compare
felixxm
reviewed
Jan 9, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
dd2eca2
to
a5a9a59
Compare
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 9, 2024
e11bits
added a commit
to e11bits/django
that referenced
this pull request
Jan 9, 2024
e11bits
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
a5a9a59
to
63b0773
Compare
|
Updated the PR as suggested. |
felixxm
changed the title
felixxm
force-pushed
the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
from
63b0773
to
9b02ad9
Compare
|
@e11bits Thanks 👍 |
e11bits
deleted the
bugfix/28404_showing_empty_value_for_empty_strings_in_django_admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to pickup ticket 28404 again. Prior PRs are #9391 #8776 and #9390 .
This is my first PR for Django, addressing not showing the empty_display_value if value is the empty string and not None in the admin app. Please advise as you see fit.
Recreated the PR from a former PR (that I closed and thought could easily reopen again).
I now check for
value in field.empty_valuesinstead onlyNoneand"", which should cover all the "empty" cases.