Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35306 -- Improved documentation for the various date format settings #18028

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

lufafajoshua
Copy link
Contributor

@lufafajoshua lufafajoshua commented Mar 28, 2024

Trac ticket number

ticket-35306

Branch description

Updated documentation on localization formats usage and precedence.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

@nessita
Copy link
Contributor

nessita commented Mar 28, 2024

@lufafajoshua thank you for your work.

When this PR is ready for review, please update the checklist from the PR description, and don't forget to set the proper ticket flags for this to be listed in the branches needing review.

docs/ref/settings.txt Outdated Show resolved Hide resolved
docs/ref/settings.txt Show resolved Hide resolved
docs/topics/i18n/formatting.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @lufafajoshua ⭐ I have a few comments
Can you also update the PR title to better represent what this PR is trying to acheive?

docs/ref/settings.txt Outdated Show resolved Hide resolved
docs/ref/settings.txt Outdated Show resolved Hide resolved
docs/ref/settings.txt Show resolved Hide resolved
docs/topics/i18n/formatting.txt Outdated Show resolved Hide resolved
docs/ref/settings.txt Outdated Show resolved Hide resolved
@sarahboyce sarahboyce changed the title Fixed #35306 -- Updated 5.0 Docs Fixed #35306 -- Improved documentation for the various date format settings Jun 21, 2024
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lufafajoshua 👍 this looks good to me!
I have squashed commits and applied minor updates, want to check other people are happy before merging but I think we're very close

Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sarahboyce sarahboyce merged commit 3ac0e43 into django:main Jun 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants