Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35470 -- Separated i18n and l10n globalization settings. #18194

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

lufafajoshua
Copy link
Contributor

Trac ticket number

ticket-35470

Branch description

Separated i18n and l10n settings to add more clarity and part of efforts to clean up localization format docs in ticket #35306.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lufafajoshua
I have a formatting suggestion 👍

docs/ref/settings.txt Outdated Show resolved Hide resolved
docs/ref/settings.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lufafajoshua ⭐ this looks good to me!
@claudep as you originally suggested this in this comment let me know if you're also happy

Plan to merge soon 👍

@claudep
Copy link
Member

claudep commented Jun 13, 2024

Sure, I am!

@sarahboyce sarahboyce merged commit 8733e9a into django:main Jun 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants