Fixed #22712 -- Avoided name shadowing of "all" in findstatic command.

[avallbona]

Fixed TICKET-22712 - Consider not using built-in functions as parameters.

Trac ticket number

ticket-22712

Branch description

Replaced the name that shadows the builtin funcion all and replaced by fetch_all. I'm not sure if we need the changes to be backwards compatible.

Checklist

• This PR targets the main branch.
• The commit message is written in past tense, mentions the ticket number, and ends with a period.
• I have checked the "Has patch" ticket flag in the Trac system.
• I have added or updated relevant tests.
• I have added or updated relevant docs, including release notes if applicable.
• I have attached screenshots in both light and dark modes for any UI changes. (N/A)

[nessita]

Thank you @avallbona for this work! It looks good 🌟

I have added some comments and I also think that we should include release notes in the 5.2.txt file, under the section Features deprecated in 5.2. Something like:

* The ``all`` argument for the ``django.contrib.staticfiles.find()`` function
  is deprecated in favor of the ``find_all`` argument.

[avallbona]

Thank you @avallbona for this work! It looks good 🌟

I have added some comments and I also think that we should include release notes in the 5.2.txt file, under the section Features deprecated in 5.2. Something like:

* The ``all`` argument for the ``django.contrib.staticfiles.find()`` function
  is deprecated in favor of the ``find_all`` argument.

Addressed the comments in 704fdb92b513ee0d6218068990bd70afa90dfdfd Thanks for the feedback 🙇🏿‍♂️

[nessita]

Thank you @avallbona for the param rename! Looks great.

Did you see my comment about kwargs? Would you have some time to do some follow up with that?

[avallbona]

Thank you @avallbona for the param rename! Looks great.

Did you see my comment about kwargs? Would you have some time to do some follow up with that?

I've answered in the comment about kwargs. Thanks for the feedback 🙇🏿‍♂️

[nessita]

Thank you @avallbona for the param rename! Looks great.
Did you see my comment about kwargs? Would you have some time to do some follow up with that?

I've answered in the comment about kwargs. Thanks for the feedback 🙇🏿‍♂️

Thank you, overall that looks good. I think that some comments such as:

# RemovedInDjango60Warning: When the deprecation ends, replace with:
# def find(self, path, find_all=False):

As a reference/example, we are just discussing/fixing a similar-ish issue for the save and asave methods. You can see how that was done in these PRs:

#17667
#18304
#18313

[avallbona]

Thank you @avallbona for the param rename! Looks great.
Did you see my comment about kwargs? Would you have some time to do some follow up with that?

I've answered in the comment about kwargs. Thanks for the feedback 🙇🏿‍♂️

Thank you, overall that looks good. I think that some comments such as:

# RemovedInDjango60Warning: When the deprecation ends, replace with:
# def find(self, path, find_all=False):

As a reference/example, we are just discussing/fixing a similar-ish issue for the save and asave methods. You can see how that was done in these PRs:

#17667 #18304 #18313

@nessita handled in 3563132ea47cb8a0a52b2558e541bbc579535c30 Thanks for the feedback 🙇🏿‍♂️

[nessita]

Thank you so much @avallbona for this work 🌟

I pushed a slight rework of the solution because, once I branched this PR to complete the review, I realized that the duplication for the deprecation check could be unified in a helper method.

I also took the opportunity to try the kwargs approach which I think worked well enough. Let me know what you think!

[nessita]

Deprecation timeline was corrected in #18321.

[avallbona]

@nessita Thanks for your support along my first code contribution. The result of the fix I think it's satisfactory and I would have liked to had the chance to fix what @felixxm has fixed.

[nessita]

@nessita Thanks for your support along my first code contribution. The result of the fix I think it's satisfactory and I would have liked to had the chance to fix what @felixxm has fixed.

Right, this was my mistake: I should have noticed the deprecation number mismatch and I should have let you know so you could correct it. I'm sorry!

(In my head, I was still on 5.1 due to the recent beta release so I mixed the target deprecation version.)