Ticket 21353 #1882
Ticket 21353 #1882
Conversation
| @@ -42,6 +42,10 @@ | |||
| {% endspaceless %} | |||
| </td> | |||
| {% for fieldset in inline_admin_form %} | |||
| {% if fieldset.description and forloop.parentloop.first %} | |||
There was a problem hiding this comment.
On looking at this a bit more, I'm not sure about it... fieldset.name isn't rendered either, maybe this was intentionally omitted in the tabular inline. Just stacking up the descriptions where they don't really correspond to the fields doesn't seem very elegant.
There was a problem hiding this comment.
@timgraham Yeah, I agree it's not very elegant. I had tried several different approaches and using forloop.parentloop.first was the only one that worked.
You make a great point about fieldset.name not being used. Now I'm thinking that fieldsets and fields have a different relationship in TabularInlines than they do in ModelAdmin and even StackedInlines. It would be bad to force more fieldset attributes into it.
I'll give it more thought. Thanks for your feedback.
There was a problem hiding this comment.
Sounds good. It may be best just to document that description doesn't apply when using TabularInlines. I'll close this PR for now. Feel free to continue the discussion on the ticket.
Fix and test for ticket 21353: 'description' key in InlineModelAdmin fieldsets is ignored
https://code.djangoproject.com/ticket/21353