Hide relationships whose related_name='+' (trac #22015) #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| accessor = rel.get_accessor_name() | ||
| # If related_name == '+', backwards relations are explicitly disabled. | ||
| if accessor == '+': |
There was a problem hiding this comment.
Actually a relation is hidden if it ends with a '+'. Here rel has a is_hidden method that abstract this check.
If related_name of a ForeignKey/M2M relationship ends with '+' (in other words, related model is hidden from the other side), user explicitly asked Django to *not* create backwards relation. This should be taken into account when rendering admindocs.
|
Could you please add a test? |
|
I would love to, however, currently only some internal helpers are tested; there is nothing to hook onto what produces 'output'. If there were, I would definitely add a test. But in this case I don't feel adventurous enough to set up a full-blown test suite for this contrib application* and so left my patch testless (and I am not doing the "full" work). [*]: if I depended more on admindocs, I would certainly do that. |
|
Ok, I've left a comment on the ticket to that effect to see if anyone else is interested in adding tests. Will close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If related_name of a ForeignKey/M2M relationship is '+', user explicitly asked Django to not create backwards relation. This should be taken into account when rendering admindocs.