-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some compatibility bits for Python 3.2. #3934
Conversation
This got me wondering if we're planing to set up something in order to make sure we don't introduce |
That seems like something that could be implemented as part of flake8. I haven't looked to see if it might exist. |
Here's a couple of candidates for the PR:
|
(current_version < (2, 7, 3)) or | ||
(current_version >= (3, 0) and current_version < (3, 2, 3)) | ||
) | ||
use_workaround = current_version < (2, 7, 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might question the support of Python < 2.7.3. I've read that Mac OS X Lion ships 2.7.1. Would this be a blocker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly either way in this case. If there were a maintenance overhead here I'd definitely be in favor of enforcing our "we only support the latest minor release" more aggressively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep that, you're right that this doesn't cost us much.
No description provided.