Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some compatibility bits for Python 3.2. #3934

Merged
merged 1 commit into from
Jan 17, 2015

Conversation

timgraham
Copy link
Member

No description provided.

@charettes
Copy link
Member

This got me wondering if we're planing to set up something in order to make sure we don't introduce u string literals now that we drop Python3.2 support. They can be easy to miss while reviewing a patch and a failure on Python3.2 was a great way of spotting them.

@timgraham
Copy link
Member Author

That seems like something that could be implemented as part of flake8. I haven't looked to see if it might exist.

(current_version < (2, 7, 3)) or
(current_version >= (3, 0) and current_version < (3, 2, 3))
)
use_workaround = current_version < (2, 7, 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might question the support of Python < 2.7.3. I've read that Mac OS X Lion ships 2.7.1. Would this be a blocker?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly either way in this case. If there were a maintenance overhead here I'd definitely be in favor of enforcing our "we only support the latest minor release" more aggressively.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that, you're right that this doesn't cost us much.

@timgraham timgraham merged commit fed25f1 into django:master Jan 17, 2015
@timgraham timgraham deleted the drop-py32 branch January 17, 2015 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants