Fixed #24467. Always include prepopulate.js to avoid JS errors #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildbot, test this please. |
|
As Simon suggested on IRC, we could make the same change for |
|
@timgraham OK, will make appropriate change and update this PR |
|
buildbot, test this please. |
|
merged in 28e8c54, thanks! |
|
I see message "This pull request is closed, but the 1st:ticket_24467 branch has unmerged commits". Do I need to press button "Delete branch"? |
|
Sure, you can do that. That just deletes the branch on your fork. |
|
@timgraham I can't find in what branch did you merge my change. I can't find it in master :-( |
|
master, please see my comment above for the commit hash. |
|
OK, I see. It's not synced changes in my local repo. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in https://code.djangoproject.com/ticket/24467 - we need to include "prepopulate.js" file always.
This bug is in Django 1.7.5 and maybe in older releases. I use 1.7.5 and fixed this bug in development branch. If I need to do this fix in other branch (for example 1.7.x) please assist me on this way.
Thank you.
Anton