Ticket #19125 #441
Ticket #19125 #441
Conversation
|
Sorry about the earlier version, I first didn't noticed there are already tests for startproject and then forgot to remove the duplicates. Ironicly, the diff on the ticket didn't have them so I didn't noticed. |
| out, err = self.run_django_admin(args) | ||
| self.assertOutput(err, "Error: '../testproject' is not a valid project name. Please make sure the name begins with a letter or underscore.") | ||
| self.assertFalse(os.path.exists(testproject_dir)) | ||
|
|
||
| def test_simple_project_different_directory(self): |
There was a problem hiding this comment.
Nitpicking: I would have reused the test_invalid_project_name test, looping on "for project_name in ('7testproject', '../testproject'):". This would allow us to test more names with less code duplication.
There was a problem hiding this comment.
There is a lot more code duplication in that TestCase then that ;)
The isolation is also poor, because it modifies Django source tree, so this won't work in parallel and won't cleanup if startproject actually makes a directory, but with malformed name. I started refactoring it, but that would make the patch quite a huge change for this ticket. I can still do it, though.
There was a problem hiding this comment.
Here's how I would have written it: https://gist.github.com/3911240. Hopefully it's not worse than the previous version.
|
Thanks for the patch, committed in 9893fa1 |
https://code.djangoproject.com/ticket/19125